TSM_Shopping ignores "Show Results Above Dealfinding Price" check box - fix included

[Theck]

TSM Versions:
TSM 1.5.8
TSM_Shopping 1.3.10

The "Show Results Above Dealfinding Price" check box in the TSM_Shopping configuration is not functioning properly. In particular, if you use either the "Get All" scan or the TSM Application, and then run a Dealfinding Search (under "Special Searches" in the TSM auction house interface), it will always refuse to show results above the dealfinding price, regardless of the checkbox's state.

I opened a ticket about this, but it was rejected with the claim that this was "working as intended." I can't see any reason why this should be working as intended, so I assume I just wasn't clear enough with the explanation. Rather than open another ticket, I took some time to peruse the code and fix the bug.

Line 439 of TSM_Shopping/modules/Search.lua contains the logic that determines which items are shown from the dealfinding scan. It reads:

        if dealfindingData and dealfindingData.maxPrice and data.minBuyout and dealfindingData.maxPrice >= data.minBuyout then

It's clear from this that it is only checking that the data exists and that the max price is greater than the buyout. There is no conditional that tests the state of the check box. Luckily, it's a very simple fix to add that conditional. Changing line 439 to read as follows corrects the problem:

        if dealfindingData and dealfindingData.maxPrice and data.minBuyout and (TSM.db.profile.dealfindingShowAboveMaxPrice or dealfindingData.maxPrice >= data.minBuyout) then

The logic in parentheses returns true if the check box is checked, or if the check box is not checked but the item's buyout is below the dealfinding max price, which is intuitively how the check box ought to work (and used to work in previous versions, this issue has only appeared since somewhere in 1.3.x, probably when Dealfinding was moved to specail searches).

Thanks to Sapu and all of the other devs for all your hard work, the addon is excellent.

[Theck]

Bumping because this issue is still present in TSM_Shopping v1.3.11. It's a simple fix, and produces intuitive behavior. A user would expect that a check box that says "Show Results Above Dealfinding Price" would do what it says it does. As it is, the check box appears to not be functioning.

[Sapu94]

Results above dealfinding price are shown with the checkbox checked: http://i.imgur.com/Mkc0p.png

As I've said, special searches won't search for items which don't meet the criteria (vendor price / disenchant price / dealfinding price). This is by design to make them faster. If you want to search for a dealfinding list regardless of whether or not there are some results below max price, you can click on it in the list. Otherwise, this is still working as intended. Sorry if it's worded in a confusing way, we will try and improve it in the future.

[Theck]

It isn't working when using a GetAll scan or with data imported from the TSM Application. After updating to v1.3.11 (from my modified version of 1.3.10), it stopped showing entries above the dealfinding price.

For example, if I use a GetAll scan and the default TSM_Shopping version, I get this:
https://sites.google.com/site/theckhd/Home/tsm1.png

(note the error message at the bottom about there being no results below my thresholds, despite having the box checked)
If I make my modification to line 439 of TSM_Shopping\modules\Search.lua, I get this:
https://sites.google.com/site/theckhd/Home/tsm2.png

There's only 2 or 3 filters active because I used GetAll, and Tichondrius' AH data dump is just too large for GetAll. I usually use the TSM Application as a result.

It's very clear why it doesn't work - line 439 contains the logic used when the "Dealfinding Search" button is pressed, and it has no reference at all to the state of the checkbox. That's all my modification does: add that conditional.

I don't understand why you insist this is working as intended. There is no speed difference to speak of here - if you leave the checkbox unchecked, it's just as fast as it was without my modification. If you do check it, of course it takes longer because it shows you more data. But presumably the user wants more data in that situation, since they are explicitly asking for it.

In addition, this mod restores the behavior that the Dealfinding Search button exhibited before it was moved to the "Special Searches" tab. I'm not sure why you decided the functionality should change, but it's far less useful in its current version, especially if you have multiple different Dealfinding Lists set up for organization reasons.

If you really want to keep the "Show Results Above Dealfinding Price" checkbox affecting only saved searches, may I suggest the following:
1) Change the name of the "Show Results Above Dealfinding Price" to "Show All Results for Saved Searches" so it's clear what it affects
2) Add another checkbox named "Show All Results for Special Searches" that enables this for Dealfinding Searches. Apart from the UI change, all that's needed is the small modification that I've made to the code.

I really love the addon, but it lost a lot of "ease-of-use" value to me when Dealfinding started acting this way. This is a very simple modification that restores a great deal of usability to the tool.

[Sapu94]

Actually the reason it says there's nothing to scan was because of a bug in AuctionDB that was fixed in v1.3.9 of AuctionDB. I'm not going to entertain a discussion about why a bug in a separate module proves your idea is the only logical action. There are many ways that you could get the functionality you want with TSM, but you don't seem interested in hearing about them.

Bottom line is, it's currently working as it's intended to work. I've already stated that we will try and make it more clear and improve the functionality in the future, but if you have specific ideas for improving the functionality, we'd love to hear about them in the correct thread. Saying "the code should work like this" isn't something I'm interested in implementing as it completely overlooks all other design decisions. Instead, describe the functionality you want to see in TSM and we will do our best to implement something which will be beneficial to all TSM users when we have time to do so.

If in the future you're having specific issues where it's not working as intended (as your first screenshot above showed), feel free to describe them in detail in a new thread and we will do our best to fix them promptly.