Register
Welcome to the Stormspire.net WoW Gold Forums!

Greetings, guest! Welcome to Stormspire.net, your #1 resource for WoW and Diablo 3 Gold, Professions, and everything in between!


Enjoy what the site offers? Consider Premium Membership if you wish to get the most out of the site. Premium Membership benefits include the acclaimed Goblineer's World of Warcraft Gold Guide, private forum access, a complimentary high-quality avatar, and much more!


If this is your first visit, make sure to check out the Stormspire.net Survival Guide for a quick site orientation. You may also register to unlock all standard forum features, and to get rid of these lovely ads!


We proudly host the Official forums for TradeSkillMaster, The Undermine Journal, and WoWuction.

Results 1 to 10 of 10
  1. #1
    US-Dreadmaul(H)
    Ethereal Contributor
    j311yf1sh's Avatar
    Posts
    196
    Reputation
    34
    Tagged in
    79 Posts
    Add to this user's reputation

    TradeSkillMaster_PriceReply

    TradeSkillMaster_PriceReply

    Download
    Curse: TradeSkillMaster_Price



    warning what you see here is based off of default settings

    TradeSkillMaster_PriceReply is a TSM Module that replies to special commands to reply with a price automatically.

    from toon1: PR: [Bold Primordial Ruby]

    to toon1: PR: MP: 3g55s85c / MB: 3g75s0c / Scanned: 0 Hrs 16 Mins Ago

    Is basically how it will reply to actions.

    It will check for PR: [itemlink] (or your set command) at the start of a sentence if it is found it will whisper the person the price in a nice format

    Currently it supports guild chat/say/whispers.

    You can make it reply back in guild or in whisper(default), as with /say it will reply in /say or whispers(default).

    How to?

    Simply type PR: [itemlink](or your specified trigger) and it will reply to the sent request in a whisper.

    Typing /tsm and going to the Price Reply module in the top right will allow you to access the options for it.

    What about lock outs?

    Current it has a default time of 15 seconds lockout but it can be changed by going into /tsm then clicking on the price reply module(Top Right)

    Future

    Not sure where this is going in the future depends on feedback.

    ideas are:
    • reply to /say - Done
    • reply to bnet whispers - Still working on
    • reply to trade chat - Possibly not worth it
    • turn off individual channels for messages - Completed
    • Blacklist people to not message - depends if wanted



    Any feedback is appreciated.

    Cheer's jf
    Last edited by Sterling; October 3rd, 2014 at 01:29 PM.
    <J311yf1sh> im gonna stare really hard at it and hope it works
    <J311yf1sh> thats how you program correct?
    Enchanting Shuffler addon - Creator of the enchanting shuffler addon
    Twitter - my twitter
    Blog - my Blog
    Please give reputation and feedback if i have helped you by clicking the star at the bottom left of this post.

  2. #2
    Entrepreneur
    Reviamjolly's Avatar
    Posts
    383
    Reputation
    15
    Tagged in
    105 Posts
    Add to this user's reputation
    I have installed the addon I have tried requesting the info from people in my guild without TSM and no joy tried in guild chat and no response.

    got a guild member to whisper me and he received no response.

    I tried this request "PR: [Brilliant Primordial Ruby]" (without the quotes) in /g /w to myself, /w to a guildie but not one gave me a response

    I am sure i am missing something.

  3. #3
    US-Dreadmaul(H)
    Ethereal Contributor
    j311yf1sh's Avatar
    Posts
    196
    Reputation
    34
    Tagged in
    79 Posts
    Add to this user's reputation
    Quote Originally Posted by Reviamjolly View Post
    I have installed the addon I have tried requesting the info from people in my guild without TSM and no joy tried in guild chat and no response.

    got a guild member to whisper me and he received no response.

    I tried this request "PR: [Brilliant Primordial Ruby]" (without the quotes) in /g /w to myself, /w to a guildie but not one gave me a response

    I am sure i am missing something.

    I will try a few tests and check and see if i can replicate the problem

    EDIT: i misread what you had written,
    " I have tried requesting the info from people in my guild without TSM" - they send you the request and the addon will reply to them automatically.

    "I tried this request "PR: [Brilliant Primordial Ruby]" (without the quotes) in /g /w to myself, /w to a guildie but not one gave me a response"

    It should have worked with a whisper to yourself, or just putting it in /g or /s should work

    Try changing the trigger.
    Enable/disable the addon(with the button in the options)
    also try reseting the settings with the button in the options
    Last edited by j311yf1sh; January 18th, 2013 at 08:42 PM.
    <J311yf1sh> im gonna stare really hard at it and hope it works
    <J311yf1sh> thats how you program correct?
    Enchanting Shuffler addon - Creator of the enchanting shuffler addon
    Twitter - my twitter
    Blog - my Blog
    Please give reputation and feedback if i have helped you by clicking the star at the bottom left of this post.

  4. #4
    Entrepreneur
    Reviamjolly's Avatar
    Posts
    383
    Reputation
    15
    Tagged in
    105 Posts
    Add to this user's reputation
    managed to get it working by changing the trigger. this was the reply I got

    19:54:09 [me]: pc: [Primordial Ruby]
    19:54:09 [me]: Price Reply: Market Price: 13g87s51c / Current Min buyout: 10g0s0c / Last scanned: 912 Hrs 54750 Mins Ago

    so I ran the profession scan and got upto date pricing for that item.

    but I will need to run a full scan as AH is 1600 pages long.

    I realised it would be a lot more accurate if it wasn't for the fact this is a fresh windows install.

    I take it any item on the auction hall it would give a price check for

  5. #5
    US-Dreadmaul(H)
    Ethereal Contributor
    j311yf1sh's Avatar
    Posts
    196
    Reputation
    34
    Tagged in
    79 Posts
    Add to this user's reputation
    Quote Originally Posted by Reviamjolly View Post
    managed to get it working by changing the trigger. this was the reply I got

    19:54:09 [me]: pc: [Primordial Ruby]
    19:54:09 [me]: Price Reply: Market Price: 13g87s51c / Current Min buyout: 10g0s0c / Last scanned: 912 Hrs 54750 Mins Ago

    so I ran the profession scan and got upto date pricing for that item.

    but I will need to run a full scan as AH is 1600 pages long.

    I realised it would be a lot more accurate if it wasn't for the fact this is a fresh windows install.

    I take it any item on the auction hall it would give a price check for
    Yeah, its best to update it using the TSM app out of game makes price checking so much easier.

    And yes any item that's been posted on the AH Should have a price for it.
    <J311yf1sh> im gonna stare really hard at it and hope it works
    <J311yf1sh> thats how you program correct?
    Enchanting Shuffler addon - Creator of the enchanting shuffler addon
    Twitter - my twitter
    Blog - my Blog
    Please give reputation and feedback if i have helped you by clicking the star at the bottom left of this post.

  6. #6
    Entrepreneur
    cracklingice's Avatar
    Posts
    824
    Reputation
    18
    Tagged in
    173 Posts
    Add to this user's reputation
    If you like myself wanted to use Wowuction data instead, I did a little bit of modification to the LUA. Must have wowuction tsm module installed and updating.

    Code:
    Out of date code removed.
    Attached Images Attached Images
    Last edited by cracklingice; March 5th, 2014 at 03:13 PM. Reason: out of date

  7. #7
    Ord
    US-Zul'jin(H)
    Wind Trader
    Ord's Avatar
    Posts
    445
    Reputation
    63
    Tagged in
    161 Posts
    Add to this user's reputation
    @j311yf1sh , I love this addon, and considered tinkering with the code myself (like @cracklingice did to use WoWuction data) but I figured I could make some suggestions instead and possibly contribute to making it better for anyone else that uses it.

    For me personally, I felt the reply was lengthy, and was looking at the code to modify the building of the price string when I realized many reply "formatting" preferences could be set in the PriceReply options. I was thinking of being able to specify up to 3 sections of replies, being able to specify the prefix for each and also use a custom price string for each value.

    To show what I mean, consider these "mock" settings:

    Response Prefix
    Reply Prefix: Ord's PriceReply -

    Price Response 1
    Prefix: Our realm's market value:
    Price Source: First(DBMarket, WoWuctionMarket)

    Price Response 2
    Prefix: My COD offer:
    Price Source: Min(90% avgBuy, 75% WoWuctionMarket)

    Price Response 3
    Prefix: Current min buyout:
    Price Source: minBuyout

    [x] Include last scan time (checkbox)

    When triggered the reply with the above settings would be:
    "Ord's PriceReply - Our realm's market value: 100g 00s 00c My COD offer: 75g 00s 00c Current min buyout: 84g 99s 99c - Last seen 1h 31 mins ago"

    You could utilize TSMAPI:ParseCustomPrice to validate entered price strings to make sure they're valid, and TSMAPI:GetCustomPriceSourceValue to return the value from that custom price string.

    I haven't done any WoW addon development really, but I wonder if this could be a little more efficient by making the chat trigger events (TSMEvents:CHAT_MSG_****) as slim as possible. Right now it looks like the addon is creating a handful of local vars and time calculations each time a message is received in any of guild, whisper, or say. I don't know if any efficiency can be gained by separating out the reply function from the chat triggers, but it should at least clean up the code a little and remove some repeated code, maybe. Consider the following pseudocode:
    Code:
    function TSMEvents:CHAT_MSG_GUILD(_,MSG,Auth)
    	if TradeSkillMaster_PriceReplyDB.AddonEnabled == false then return nil end
    	elseif string.find(MSG,Trigger) == nil then return nil end
    	else TSM:PriceReply(MSG, "GUILD")
    	end
    
    function TSMEvents:CHAT_MSG_SAY(_,MSG,Auth)
    	if TradeSkillMaster_PriceReplyDB.AddonEnabled == false then return nil end
    	elseif string.find(MSG,Trigger) == nil then return nil end
    	else TSM:PriceReply(MSG, "SAY")
    	end
    	
    function TSMEvents:CHAT_MSG_WHISPER(_,MSG,Auth)
    	if TradeSkillMaster_PriceReplyDB.AddonEnabled == false then return nil end
    	elseif string.find(MSG,Trigger) == nil then return nil end
    	else TSM:PriceReply(MSG, "WHISPER")
    	end
    
    function TSM:PriceReply(MSG, CHAN)
    	[... contine to parse string and create local vars and determine price and reply to CHAN if all valid ...]
    	end
    Also, I noticed you wrote the TSM:ConvertPriceToMoney function but you may or may not want to instead use TSM's existing TSMAPI:FormatTextMoney function. I'm not sure if you tried this already or if there were other reasons to using your own function but TSM's built-in function should be able to do it for you including formatting with colors, I believe.

  8. #8
    US-Dreadmaul(H)
    Ethereal Contributor
    j311yf1sh's Avatar
    Posts
    196
    Reputation
    34
    Tagged in
    79 Posts
    Add to this user's reputation
    Quote Originally Posted by Ord View Post
    @j311yf1sh , I love this addon, and considered tinkering with the code myself (like @cracklingice did to use WoWuction data) but I figured I could make some suggestions instead and possibly contribute to making it better for anyone else that uses it.

    For me personally, I felt the reply was lengthy, and was looking at the code to modify the building of the price string when I realized many reply "formatting" preferences could be set in the PriceReply options. I was thinking of being able to specify up to 3 sections of replies, being able to specify the prefix for each and also use a custom price string for each value.

    To show what I mean, consider these "mock" settings:

    Response Prefix
    Reply Prefix: Ord's PriceReply -

    Price Response 1
    Prefix: Our realm's market value:
    Price Source: First(DBMarket, WoWuctionMarket)

    Price Response 2
    Prefix: My COD offer:
    Price Source: Min(90% avgBuy, 75% WoWuctionMarket)

    Price Response 3
    Prefix: Current min buyout:
    Price Source: minBuyout

    [x] Include last scan time (checkbox)

    When triggered the reply with the above settings would be:
    "Ord's PriceReply - Our realm's market value: 100g 00s 00c My COD offer: 75g 00s 00c Current min buyout: 84g 99s 99c - Last seen 1h 31 mins ago"

    You could utilize TSMAPI:ParseCustomPrice to validate entered price strings to make sure they're valid, and TSMAPI:GetCustomPriceSourceValue to return the value from that custom price string.

    I haven't done any WoW addon development really, but I wonder if this could be a little more efficient by making the chat trigger events (TSMEvents:CHAT_MSG_****) as slim as possible. Right now it looks like the addon is creating a handful of local vars and time calculations each time a message is received in any of guild, whisper, or say. I don't know if any efficiency can be gained by separating out the reply function from the chat triggers, but it should at least clean up the code a little and remove some repeated code, maybe. Consider the following pseudocode:
    Code:
    function TSMEvents:CHAT_MSG_GUILD(_,MSG,Auth)
    	if TradeSkillMaster_PriceReplyDB.AddonEnabled == false then return nil end
    	elseif string.find(MSG,Trigger) == nil then return nil end
    	else TSM:PriceReply(MSG, "GUILD")
    	end
    
    function TSMEvents:CHAT_MSG_SAY(_,MSG,Auth)
    	if TradeSkillMaster_PriceReplyDB.AddonEnabled == false then return nil end
    	elseif string.find(MSG,Trigger) == nil then return nil end
    	else TSM:PriceReply(MSG, "SAY")
    	end
    	
    function TSMEvents:CHAT_MSG_WHISPER(_,MSG,Auth)
    	if TradeSkillMaster_PriceReplyDB.AddonEnabled == false then return nil end
    	elseif string.find(MSG,Trigger) == nil then return nil end
    	else TSM:PriceReply(MSG, "WHISPER")
    	end
    
    function TSM:PriceReply(MSG, CHAN)
    	[... contine to parse string and create local vars and determine price and reply to CHAN if all valid ...]
    	end
    Also, I noticed you wrote the TSM:ConvertPriceToMoney function but you may or may not want to instead use TSM's existing TSMAPI:FormatTextMoney function. I'm not sure if you tried this already or if there were other reasons to using your own function but TSM's built-in function should be able to do it for you including formatting with colors, I believe.

    There are plans in the work for creating your own price request system someone mentioned on the actual curse page.
    <J311yf1sh> im gonna stare really hard at it and hope it works
    <J311yf1sh> thats how you program correct?
    Enchanting Shuffler addon - Creator of the enchanting shuffler addon
    Twitter - my twitter
    Blog - my Blog
    Please give reputation and feedback if i have helped you by clicking the star at the bottom left of this post.

  9. #9
    Entrepreneur
    cracklingice's Avatar
    Posts
    824
    Reputation
    18
    Tagged in
    173 Posts
    Add to this user's reputation
    Last night for some reason I got this idea that I wanted error messages in the addon if there was no data for my realm and if someone was trying to get a reply too soon. This mod requires the wowuction module and the tsm app to update it. This mod using wowuction only for region data and uses auctiondb for local data. To use this, right click save as the attached EventDetection.txt and save it in the WorldofWarcraft\interface\AddOns\TradeSkillMaster_ PriceReply\Modules folder as EventDetection.lua. Back up the old file if you want to be able to go back to the unmodified version without a complete re install.

    A friend helped me find a situation that wasn't reporting properly. Has DBMarket, but no DBMinBuyout. Edited to fix that part.
    Attached Images Attached Images
    Attached Files Attached Files
    Last edited by cracklingice; March 6th, 2014 at 05:40 AM.

  10. #10
    EU-Turalyon(A), multiple others.
    Ethereal Contributor
    Branikald's Avatar
    Posts
    397
    Reputation
    14
    Tagged in
    128 Posts
    Add to this user's reputation
    Quote Originally Posted by cracklingice View Post
    Last night for some reason I got this idea that I wanted error messages in the addon if there was no data for my realm and if someone was trying to get a reply too soon. This mod requires the wowuction module and the tsm app to update it. This mod using wowuction only for region data and uses auctiondb for local data. To use this, right click save as the attached EventDetection.txt and save it in the WorldofWarcraft\interface\AddOns\TradeSkillMaster_ PriceReply\Modules folder as EventDetection.lua. Back up the old file if you want to be able to go back to the unmodified version without a complete re install.

    A friend helped me find a situation that wasn't reporting properly. Has DBMarket, but no DBMinBuyout. Edited to fix that part.
    This is exactly what I've been looking for, thank you very much.

    I'm honestly completely clueless with programming or writing addons like this, but would it be somehow possible to include the std. deviation in the region and/or local market?
    Live to win.

 

 

Similar Threads

  1. FYI: Beta will end around Sept 11.
    By Slickrock in forum Archive (Speculation)
    Replies: 1
    Last Post: August 18th, 2012, 03:09 PM
  2. Beta
    By Timecunning in forum Archive (Speculation)
    Replies: 6
    Last Post: March 31st, 2012, 02:51 PM
  3. Cataclysm Beta
    By Kiseki in forum Archive (Speculation)
    Replies: 16
    Last Post: November 9th, 2010, 11:51 AM